Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use urllib.urljoin where appropriate #986

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: Use urllib.urljoin where appropriate #986

merged 2 commits into from
Aug 14, 2024

Conversation

SebastianNiehusAA
Copy link
Contributor

TASK: PHS-636

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA merged commit cad4298 into main Aug 14, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the PHS-636-url-join branch August 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mveleci mveleci mveleci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianNiehusAA @mveleci @NiklasKoehneckeAA